Upgrade raw-window-handle to 0.5.0 #5
Conversation
It seems there's no pattern of `let _: ()`/`let (): ()`/`let (): _` binding that circumnavigates this clippy warning: ignore it instead.
| #[cfg(target_os = "macos")] | ||
| pub mod appkit; | ||
| #[cfg(target_os = "ios")] | ||
| pub mod uikit; |
There was a problem hiding this comment.
@msiglreith I thought I left a comment here but that was on your 0.4 PR, thoughts?
@msiglreith I've been looking into reviving the related
ash-windowPR now thatraw-window-handle 0.5is out and used inwinit 0.27, and stumbled upon these cfgs. According to https://github.com/rust-windowing/raw-window-handle/pull/70/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759 (surprisingly the author detailed/justified nothing of this in PR/commit messages...) it should be possible to use these acrossmacosandiosnow when targeting "Mac Catalyst"?
There was a problem hiding this comment.
As it passes builds I'm happy with it, given these are not strictly iOS/macOS anymore (as it was in the past).
There was a problem hiding this comment.
Note that I moved these to the top of the file with #![cfg(any(target_os = "macos", target_os = "ios"))], since it's still all limited to Apple platforms.
|
Thanks, version 0.3.0 published to crates.io |
|
Thanks, using it now in |
* ash-window: Upgrade to raw-window-handle 0.5.0 * Bump `raw-window-metal` to recently-released `0.3` rust-windowing/raw-window-metal#5 * examples: Bump `winit` to `0.27.1` to resolve our MSRV tests While the examples technically aren't part of our MSRV requirement (it's nice, but core crate compatibility is much more important), it's annoying to exempt these especially now that `winit` removed some unneeded MSRV 1.60/1.61 requirements. * Take `Raw{Display,Window}Handle` directly instead of through trait
* ash-window: Upgrade to raw-window-handle 0.5.0 * Bump `raw-window-metal` to recently-released `0.3` rust-windowing/raw-window-metal#5 * examples: Bump `winit` to `0.27.1` to resolve our MSRV tests While the examples technically aren't part of our MSRV requirement (it's nice, but core crate compatibility is much more important), it's annoying to exempt these especially now that `winit` removed some unneeded MSRV 1.60/1.61 requirements. * Take `Raw{Display,Window}Handle` directly instead of through trait
No description provided.