Make integer handles use non-zero types #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In similar spirit as #136.
I'm not sure myself that this is such a good idea, mainly because:
c_int/c_long
types are not possible to convert to non-zero types in the same manner (leading to us only using the API in some places).Other options would be to panic on
0
in the constructor (a weak check against invalid handles, assuming those are exceedingly rare), or we could document that it is a bug in the implementer (as opposed to the consumer) to provide zero handles where unexpected?