Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: Fix UB in Context::create_context #1441

Closed
wants to merge 1 commit into from
Closed

iOS: Fix UB in Context::create_context #1441

wants to merge 1 commit into from

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Aug 12, 2022 •
edited
Loading

We were calling an init method on the same object multiple times, which is not allowed in Objective-C.

Found while making #1440. With this change I can now run glutin on my old iPad.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@madsmtm
iOS: Fix UB in Context::create_context
6e9a05f 
You can't call `init` on something more than once
@madsmtm madsmtm mentioned this pull request Aug 13, 2022
Merged
@kchibisov
Copy link
Member

There's no ios anymore.

@kchibisov kchibisov closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsmtm @kchibisov