feat: include Cargo.lock in version control #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> [!Note] > This does not affect the test server, it will still use the latest > version of the dependecies. This has various benefits described [here](https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control) in the Cargo Book. I would specially like to highlight: - Running `git bisect` to find the root cause of a bug - Ensuring CI only fails due to new commits and not external factors - Reducing confusion when contributors see different behavior as compared to other contributors or CI The main drawbacks are: - More likely to get merge conflicts. - False sense of security (`cargo add` and `cargo install` do not respect `Cargo.lock` by default). In my opinion the benefits of deterministic CI outweight the drawbacks of extra merge conflicts. Signed-off-by: Jalil David Salamé Messina <[email protected]>
qwandor
approved these changes
Dec 5, 2023
|
@jalil-salame According to rust-lang/cargo#315 (comment), we should not add I think what you want to do is to add Cargo.lock to repo for test_server which is a binary. |
That comment is outdated, but looking at Tokio and other big libraries they don't add a Cargo.lock so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This does not affect the test server, it will still use the latest version of the dependecies.
This has various benefits described here in the Cargo Book.
I would specially like to highlight:
git bisectto find the root cause of a bugThe main drawbacks are:
cargo addandcargo installdo not respectCargo.lockby default).In my opinion the benefits of deterministic CI outweight the drawbacks of extra merge conflicts.