Add build support on riscv64 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImBearChild
requested review from
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
|
Hello, I'm just checking in on this PR as it's been a while since there's been any activity. I'm eager to get your feedback and incorporate any suggestions you may have. Please let me know if you have any questions or require further clarification. |
roypat
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Hi, sorry for the delay. We're still trying to figure out how to best realize riscv64 support in rust-vmm, mainly wrt testing - we'll be talking about it at the next community sync next week monday!
As for this specific PR though, since it'd just relaxing the target_arch cfgs, I think that's fine to just merge. There's quite a few in there that we don't currently test already, so adding risc isn't gonna make anything worse here I'd say
roypat
reviewed
Jul 24, 2024
Relaxing the target_arch cfgs for riscv64 Signed-off-by: Nianqing Yao <[email protected]>
roypat
approved these changes
Aug 5, 2024
stefano-garzarella
approved these changes
Aug 5, 2024
TimePrinciple
added a commit
to TimePrinciple/vm-memory
that referenced
this pull request
Oct 7, 2024
To incorporate: - [[rust-vmm#287](rust-vmm#287)] Support for RISC-V 64-bit platform. - [[rust-vmm#299](rust-vmm#299)] atomic_bitmap: support enlarging the bitmap. Signed-off-by: Ruoqing He <[email protected]>
TimePrinciple
added a commit
to TimePrinciple/vm-memory
that referenced
this pull request
Oct 9, 2024
To incorporate: - [[rust-vmm#287](rust-vmm#287)] Support for RISC-V 64-bit platform. - [[rust-vmm#299](rust-vmm#299)] atomic_bitmap: support enlarging the bitmap. Signed-off-by: Ruoqing He <[email protected]>
roypat
pushed a commit
that referenced
this pull request
Oct 9, 2024
To incorporate: - [[#287](#287)] Support for RISC-V 64-bit platform. - [[#299](#299)] atomic_bitmap: support enlarging the bitmap. Signed-off-by: Ruoqing He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This pull request adds support for building the project on RISC-V 64 (riscv64) architectures. Building has been tested successfully on Fedora.
You can test it by building rpm from this repo:
https://src.fedoraproject.org/fork/imbearchild/rpms/rust-vm-memory/tree/rawhide-rv64
(Since Fedora do not have official rv64 support at this moment, you can use a third-party Fedora port from PLCT lab, both OCI image and disk image is available. If you want to use it, please refer to Fedora Wiki for more information on this topic.)
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.