vhost-device-gpu: Expose more options as CLI flags #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add command line arguments for configuring which capsets and features are enabled when configuring Rutabaga. Since we now specify the capsets explicitly we can drop the MAX_NUM_CAPSETS constant and fix the TODO. If the user selects virglrender the capsets are configured the default capset configuration is suitable for running virgl/venus guests. If the user select gfxstream, by default only vulkan is enabled, this is suitable for running Android with gfxstream. Signed-off-by: Matej Hrica <[email protected]>
The name of the project/backend is "virglrenderer", the dash was added by clap. Adding the dash seems confusing to the user, the old name is kept as a hidden alias. Signed-off-by: Matej Hrica <[email protected]>
This was an oversight, for the user to be able to use the crate as a library, the start_backend should be part of the public API. Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR allows the user to configure more flags, that are passed to
Rutabaga. By specifying the individual capsets explicitly this also fixes a TODO, which hard-coded the number of enabled capsets.Note: While you can enable some features using this, such as Venus or gfxstream-vulkan, these capsets are not really useful without blob resource support (to be added in other PR, depends on changes to QEMU) - you can enable the capsets, but not anything useful using them. This has been the case prior to this PR, but the capsets were just enabled implicitly.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.