chore: Refactor toolchain versioning #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RUST_TOOLCHAIN` is defined separately in each `Dockerfile`, it's easy to be left behind when trying to update rust toolchain version. By moving into `build_containers.sh`, effectively eliminates the possibility of having different rust toolchain version on different architectures. Signed-off-by: Ruoqing He <[email protected]>
Previous implementation would produce too much useless hint, which leads to unnecessarily long log output. Signed-off-by: Ruoqing He <[email protected]>
TimePrinciple
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat and
ShadowCurse
as code owners
rbradford
previously approved these changes
Oct 4, 2024
Unit-tests in `kvm-ioctls` requires at least 4 cores to pass, change `MIN_CORES` to 4 to meet that predicate. Signed-off-by: Ruoqing He <[email protected]>
|
Running this version locally: 
It fails because 
Everything works well, the dialing output is effectively reduced :) |
rbradford
approved these changes
Oct 5, 2024
roypat
approved these changes
Oct 7, 2024
TimePrinciple
added a commit
to TimePrinciple/rust-vmm-ci
that referenced
this pull request
Oct 7, 2024
Version v47 [1] incorporates: - chore: Move RUST_TOOLCHAIN into build_container.sh - chore: Refactor dialing to reduce useless hints - riscv64: Set MIN_CORES to 4 [1] rust-vmm/rust-vmm-container#118 Signed-off-by: Ruoqing He <[email protected]>
This was referenced Oct 7, 2024
ShadowCurse
pushed a commit
to rust-vmm/rust-vmm-ci
that referenced
this pull request
Oct 7, 2024
Version v47 [1] incorporates: - chore: Move RUST_TOOLCHAIN into build_container.sh - chore: Refactor dialing to reduce useless hints - riscv64: Set MIN_CORES to 4 [1] rust-vmm/rust-vmm-container#118 Signed-off-by: Ruoqing He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
RUST_TOOLCHAINis defined separately in eachDockerfile, it'seasy to be left behind when trying to update rust toolchain version. By
moving into
build_containers.sh, effectively eliminates thepossibility of having different rust toolchain version on different
architectures.
to unnecessarily long log output.
This PR also updates rust toolchain version to 1.80.1 on riscv64.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.