Switch to rust-vmm-ci #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2020 20:19
Signed-off-by: Alexandra Iordache <[email protected]>
Signed-off-by: Alexandra Iordache <[email protected]>
alxiord
force-pushed
the
ci
branch
2 times, most recently
from
cacae16 to
698de33
Compare
Signed-off-by: Alexandra Iordache <[email protected]>
|
@andreeaflorescu the build is successful, but the webhook didn't get the message, help? 😃 |
This was some draft PR black magic. Once updated to ready-for-review PR, the correct status is reported. |
sboeuf
previously approved these changes
Mar 5, 2020
andreeaflorescu
requested changes
Mar 5, 2020
| @@ -18,16 +18,17 @@ cargo build | |||
| Our Continuous Integration (CI) pipeline is implemented on top of | |||
There was a problem hiding this comment.
Hmm, the readme should be updated as well now that we use the rust-vmm-ci directly. In other repositories we just linked the rust-vmm-ci and got rid of all the other details.
added 4 commits
March 5, 2020 18:26
Signed-off-by: Alexandra Iordache <[email protected]>
Signed-off-by: Alexandra Iordache <[email protected]>
Signed-off-by: Alexandra Iordache <[email protected]>
Signed-off-by: Alexandra Iordache <[email protected]>
Done |
andreeaflorescu
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
rust-vmm-cipipeline, using the one from the submodule instead(Still not very sure of what I'm doing, please call out any stupid stuff)