Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ElementRef Debug impl use Element #190

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Make ElementRef Debug impl use Element #190

merged 1 commit into from
Jul 31, 2024

Conversation

gfaster
Copy link
Contributor

@gfaster gfaster commented Jul 30, 2024

fixes #186

@gfaster
Make ElementRef Debug impl use Element
f5cc684 
The derived impl would print out the whole tree. This caused selectors
to log many GBs per minute.
@gfaster
Copy link
Contributor Author

gfaster commented Jul 30, 2024

There is still a ton of log output, but this should make it significantly more sane

@cfvescovo cfvescovo merged commit 9242d09 into rust-scraper:master Jul 31, 2024
5 checks passed
@andreievg andreievg mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scraper logs 1gb
3 participants
@gfaster @adamreichold @cfvescovo