Fix filling buffers 4 GiB or larger with OsRng::fill_bytes on Windows #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| io::Error::last_os_error()); | ||
| // CryptGenRandom takes a DWORD (u32) for the length so it only supports | ||
| // writing u32::MAX bytes at a time. | ||
| for slice in v.chunks_mut(u32::MAX as usize) { |
There was a problem hiding this comment.
Could this use <DWORD>::max_value()? That should help avoid the import and also avoid hardcoding u32 == DWORD
CryptGenRandom takes a DWORD (u32) for the length so it only supports writing u32::MAX bytes at a time. Casting the length from a usize caused truncation meaning the whole buffer was not always filled.
ollie27
force-pushed
the
win_fill_bytes
branch
from
1c9ee86
to
ae61549
Compare
|
Fixed that small nit. Do you want me submit the same patch to rust-lang/rust as that also has the same problem? |
alexcrichton
added a commit
that referenced
this pull request
Feb 24, 2016
Fix filling buffers 4 GiB or larger with OsRng::fill_bytes on Windows
|
Thanks! Yeah you can submit one, although it probably doesn't matter much as we're not taking user-specified buffers anyway |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 26, 2016
CryptGenRandom takes a DWORD (u32) for the length so it only supports writing u32::MAX bytes at a time. Casting the length from a usize caused truncation meaning the whole buffer was not always filled. cc #31841 This is the same as rust-random/rand#99. I think it's a good idea to keep the implementations in sync. r? @alexcrichton
pitdicker
pushed a commit
to pitdicker/rand
that referenced
this pull request
Apr 4, 2018
Fix filling buffers 4 GiB or larger with OsRng::fill_bytes on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CryptGenRandom takes a DWORD (u32) for the length so it only supports
writing u32::MAX bytes at a time.
Casting the length from a usize caused truncation meaning the whole buffer
was not always filled.
cc rust-lang/rust#31841