Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors on nightly (alloc crate changes) #545

Merged
merged 2 commits into from
Jul 11, 2018

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Jul 10, 2018

No description provided.

@dhardy
Copy link
Member Author

dhardy commented Jul 10, 2018

Aside from the import syntax not working on older compilers, it seems from_bits was not available in libcore before 1.25.0 (strangely, the CI test doesn't seem to pick this up, but local builds do).

Is it time to increase the minimum compiler version? It would fix these two issues.

@dhardy
Copy link
Member Author

dhardy commented Jul 11, 2018

No, raising the version to 1.25.0 does not fix this (see rust-lang/rust#46931 (comment)).

@dhardy dhardy merged commit 74c68bf into rust-random:master Jul 11, 2018
@dhardy dhardy deleted the nightly branch July 11, 2018 09:57
@dhardy dhardy mentioned this pull request Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant