Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Criterion as dev-dependency, fix CI for MSRV and minimal-versions #1275

Merged
merged 2 commits into from
Dec 11, 2022

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Dec 11, 2022

This adds two workarounds to CI tests:

  • MSRV: we now have a Cargo.lock.msrv file to force specific versions of dependencies when testing the minimal Rust version. This should make CI more robust (Minimum Rust Version matklad/once_cell#201).
  • Minimal-versions: override version of an independency (which is a dep of Criterion)

@dhardy dhardy force-pushed the work2 branch 3 times, most recently from 4af7539 to d29ce3f Compare December 11, 2022 13:01
Copy link
Collaborator

@vks vks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants