Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for older Linux kernels #153

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Conversation

newpavlov
Copy link
Member

Minimum supported kernel version got bumped to 2.6.32 in rust-lang/rust#74163

Minimum supported kernel version got bumped to 2.6.32 in rust-lang/rust#74163
@newpavlov newpavlov requested a review from josephlr July 19, 2020 18:28
@newpavlov newpavlov added this to the 0.2 milestone Jul 19, 2020
@newpavlov
Copy link
Member Author

CI failures look unrelated to changes in this PR.

@dhardy
Copy link
Member

dhardy commented Jul 20, 2020

Presumably that change will appear in Rust 1.46.0, which means that in theory we should not remove this workaround until the MSRV ≥ 1.46.

On the other hand, I doubt many people actually care about using the latest getrandom on such an ancient system, so it's likely unimportant. @josephlr?

@newpavlov
Copy link
Member Author

newpavlov commented Jul 20, 2020

Presumably that change will appear in Rust 1.46.0

I don't think so. Libraries having stricter OS requirements than std is not unusual, e.g. think of crates which utilize io-uring. By this logic they would have MSRV which will not be released in a decade or so.

We had two reasons for the workaround: possibility of getrandom being used by std and the fact that it's part of Firefox dependency tree. Since RHEL and CentOS no longer block the update, I think we can go forward with this change. And we are being extra careful by releasing it as part of v0.2. and not v0.1.

Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Regarding the above comments:

  • This makes Linux 2.6.23 the minimum supported kernel for getrandom 0.2
  • This does not affect the MSRV, as old versions of Rust (on not-ancient kernels) will still work fine
  • Having this as part of 0.2 seems correct (to avoid breakage), although ~0 people actually care
  • We're making this change at the same time as Rust's libstd only because we target roughly the same support as libstd. There are no depedancies between these changes
  • CI issues are unrelated (see stdweb: Remove CI runs with cargo-web #154 and rustfmt: Run cargo fmt #155)

@josephlr josephlr merged commit 2b03b0e into 0.2 Jul 22, 2020
@josephlr josephlr deleted the remove_workaround branch July 22, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants