test-runner: Improve uninstall_protocol_interface example #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a protocol is installed with a data pointer, you have to pass that same pointer in when uninstalling the interface. Update the test runner to demonstrate how to do this by opening the protocol and converting the ScopedProtocol to a raw pointer.
phip1611
force-pushed
the
bishop-uninstall-example
branch
from
f7f0f98
to
4e43642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a protocol is installed with a data pointer, you have to pass that same pointer in when uninstalling the interface. Update the test runner to demonstrate how to do this by opening the protocol and converting the ScopedProtocol to a raw pointer.
#921
Checklist