-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SCSI Protocol support #1155
Open
sky5454
wants to merge
12
commits into
rust-osdev:main
Choose a base branch
from
sky5454:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and `ExtScsiIoScsiRequestPacket`. refer to UEFI 2.10 spec docs.
…w `execute_scsi_command` send req packet is ok. **PASSED**: - SCSI_IO all api, SCSI_THRU `mode()` and `reset()` api, are test passed. **PROBLEM**: 1. panic at allocator.rs while test_scsi_io return; 2. still problem with `DevicePath`,`target_id`,`pass_thru`; **UNKNOWN**: - scsi req ok but resp without test at `execute_scsi_command()`.
after you review the code and resolve the panic, you could merge it. |
# Conflicts: # uefi-test-runner/examples/scsi.rs
Before I review fully, it would help to do some cleanup:
This will make review easier :) |
sry, has no time to cleanup it for my tired life, just review/reedit and merge it plz. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Only preliminary support.
some problem I faced:
Reader/Writer trait
ScsiIoScsiRequestPacket
/ExtScsiIoScsiRequestPacket
to be conveniently used in RustDevice Path Protocol
TARGET_MAX_BYTES
unused, for: The Target is an array of size TARGET_MAX_BYTES and it represents the id of the SCSI device to send the SCSI Request Packet.After read "SPC" which docs from T10 (SCSI Standard Groups), I Know that in_data_buffer,out_data_buffer,sense_data,cdb have variable length. so I decide to make a struct like
but data couldn't share between FFI and c. That's a problem. We should share those data by ptr.
according to uefi scsi usage from edk2:
write:
read: