Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds safe constructor and initialization for Heap #55

Merged
merged 3 commits into from
Oct 17, 2021
Merged

Adds safe constructor and initialization for Heap #55

merged 3 commits into from
Oct 17, 2021

Conversation

HeroicKatora
Copy link
Contributor

@HeroicKatora HeroicKatora commented Oct 7, 2021 •
edited
Loading

No description provided.

@HeroicKatora
Copy link
Contributor Author

Safety comments are inline in the comments and methods. Unfortunately the tests don't run under Miri due to alignment issues else I would have checked everything against Miri's memory model as well.

phil-opp
phil-opp reviewed Oct 16, 2021
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a few comments inline, otherwise this looks good to me.

Unfortunately the tests don't run under Miri due to alignment issues

Could you clarify this?

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/test.rs Outdated Show resolved Hide resolved
@phil-opp phil-opp mentioned this pull request Oct 16, 2021
Merged
@HeroicKatora
Copy link
Contributor Author

All the review comments should be resolved. Regarding Miri passing, it potentially requires a bit of a rework anyways because of passing pointers as usize which isn't compatible with the strictest interpretation of pointer provenance. And it shouldn't have an impact in practice (right now).

@phil-opp
Copy link
Member

Thanks a lot!

@phil-opp phil-opp enabled auto-merge October 17, 2021 15:44
@phil-opp phil-opp merged commit 819aa03 into rust-osdev:master Oct 17, 2021
phil-opp added a commit that referenced this pull request Oct 17, 2021
@phil-opp
Update changelog for #55
4941320
@phil-opp
Copy link
Member

Published together with #54 as v0.9.1

@phil-opp phil-opp mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeroicKatora @phil-opp