Use new inline assembly syntax for the 0.9 series #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
Nov 24, 2021
bjorn3
commented
Nov 24, 2021
It currently happens to work fine using cg_llvm as the global_asm!() ends up in the same cgu as the use of this global. There is no guarantee that this will always be the case and in fact in case of cg_clif this happens to not be the case, thus causing a linker error.
bjorn3
force-pushed
the
new_asm_for_0_9
branch
from
4868874
to
4057db1
Compare
phil-opp
approved these changes
Jan 9, 2022
|
Published as v0.9.21 |
phil-opp
added a commit
that referenced
this pull request
Jan 9, 2022
|
Would it be possible to push v0.9.21 to crates.io? Many thanks. |
|
@SlyMarbo Sorry, I forgot to do the actual |
|
Amazing! Thanks for all your hard work. It's really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.