added BigUint::count_ones(), trailing_ones() #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
requested changes
Nov 10, 2020
BartMassey
force-pushed
the
count-ones-etc
branch
from
43c3f7c
to
05ba086
Compare
BartMassey
force-pushed
the
count-ones-etc
branch
from
05ba086
to
7a1814f
Compare
BartMassey
changed the title
|
Thanks very much for the careful review and catching all the paper bag bugs. I think this gets all your suggested changes… |
|
Thanks! bors r+ |
|
Thank you! |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
BigUint::count_ones(),BigUint::trailing_ones(). Also minimal tests for these andBigUint::trailing_zeros().Closes Issue #174