-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TryFrom impls #123
Add TryFrom impls #123
Conversation
FWIW, I rebased this to resolve the conflicts. It looks good!
I'm still thinking about this before merging, because it would be a minor breaking change to add it later. For example, given I'm somewhat inclined to add by-value |
I pushed a relevant commit; This should cover most, if not all, by-value fallible conversion between primitives, |
I added a couple tweaks for simplification, but otherwise it looks good, thanks! bors r+ |
Build succeeded |
Closes #120
Currently contains:
TryFrom
translations of existing conversion traits.TryFrom
implementations.Additional implemetations (e.g.
TryFrom<BigInt> for BigUint
which skipsclone()
) could be beneficial. Also, no new tests have been added since all new impls are basically thin adapters around existing, tested methods. It may be beneficial to add them regardless.