Support extended ACKs #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 83.49% 91.24% +7.74%
==========================================
Files 7 6 -1
Lines 515 845 +330
==========================================
+ Hits 430 771 +341
+ Misses 85 74 -11 ☔ View full report in Codecov by Sentry. |
Extended ACKs allow to add TLVs to control messages to indicate more details, e.g. to provide a textual error message. Extend the error message to support reading these TLVs. For this it is required to properly consider the optional payload of the original request depending on the NLM_F_CAPPED flag. Signed-off-by: Florian Kauer <[email protected]>
koalo
force-pushed
the
devel/koalo/ext-ack
branch
from
d4a337e
to
52fe764
Compare
|
I added several more test cases, so the coverage should be much better now. |
|
Any opinion on this? I really would like to provide more contributions to rust-netlink but this PR currently blocks it :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended ACKs allow to add TLVs to control messages to indicate more details, e.g. to provide a textual error message.
Extend the error message to support reading these TLVs. For this it is required to properly consider the optional payload of the original request depending on the
NLM_F_CAPPED flag.