Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to docs #981

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Add logo to docs #981

merged 1 commit into from
Apr 15, 2021

Conversation

jturner314
Copy link
Member

@jturner314 jturner314 commented Apr 15, 2021

I noticed the logo in the upper left corner of the wgpu docs and thought it was kind of fun, so I've created this PR. This is the same logo I created for the rust-ndarray GitHub organization. The Ferris crab inside of the brackets is from here; it's licensed as CC0 (public domain).

Note that the image URL will not work until this is merged (since the image will be hosted by GitHub). Edit: I just saw that a PNG version of the logo is currently located in the GitHub pages repository. Would it be better to host the image from GitHub Pages instead?

@bluss
Copy link
Member

bluss commented Apr 15, 2021

I don't know if github pages or githubusercontent is the best one, depends on what github thinks about serving files out of the latter? They probably tolerate a lot of that, but there are solutions like https://gitcdn.link/ for that too (so it must mean there is some drawback like throttling? https://stackoverflow.com/questions/8779197/how-to-link-files-directly-from-github-raw-github-com

Use pages if you want. It should only be hosting an ancient version of the rustdoc (that's redirecting to docs.rs) (no need to change anything about the redirect I guess)

Copy link
Member

@bluss bluss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good solution, but we can use pages too if you want

@bluss bluss added this to the 0.15.2 milestone Apr 15, 2021
@jturner314
Copy link
Member Author

I've uploaded the logo to the rust-ndarray/rust-ndarray.github.io repository.

I did notice that the only other image in the docs (the one for .axis_iter()) is hosted from the gh-pages GitHub Pages branch on this repository rather than the separate repository, but there's also a similar image in the separate repository. I'm not sure what the intent is with respect to the gh-pages branch here vs. the separate repository.

@jturner314 jturner314 merged commit 47626e4 into rust-ndarray:master Apr 15, 2021
@jturner314 jturner314 deleted the docs-logo branch April 15, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants