Rename genrows/gencolumns to rows/columns #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use replacements .nrows() and .ncols() respectively
bluss
force-pushed
the
rename-rows-columns
branch
from
8b3c652
to
6d7bb73
Compare
Rename these to give them clearer names. Rows is for rows (and generalized rows, which is a bit strange). Columns is for columns (and generalized ones). Generalized just means that we take the concept of rows/columns and somehow extend it to n-dimension arrays. The old names .genrows/gencolums/_mut are deprecated
bluss
force-pushed
the
rename-rows-columns
branch
from
6d7bb73
to
a478493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove these old functions which were deprecated:
nrowsandncols)Now we can use the rows/cols method names for something better!
Rename the following without behaviour change:
The old names are deprecated. New names should be easier to understand. Note that the rows/columns names make most sense with two-dim arrays, with others it has a "generalized" meaning (see docs) - using
lanesinstead might be better for clarity sometimes.Fixes #698