Add .nrows(), .ncols() and old names .rows(), .cols() are now deprecated #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated .rows()/.cols() are renamed to nrows/ncols respectively, to make space for putting the row iterable/ndproducer in this place instead. The deprecated methods will be removed in the release after they were first deprecated.
bluss
changed the title
examples/life.rs
Outdated
| @@ -58,7 +58,7 @@ fn iterate(z: &mut Board, scratch: &mut Board) { | |||
| } | |||
|
|
|||
| fn turn_on_corners(z: &mut Board) { | |||
| let n = z.rows(); | |||
| let n = z.nrows(); | |||
| let m = z.cols(); | |||
There was a problem hiding this comment.
This cols call escaped your purge @bluss 👀
There was a problem hiding this comment.
I fixed that one and another instance I found.
|
🌟 teamwork 🥇 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.rows()/.cols() are renamed to nrows/ncols respectively, to make space
for putting the row iterable/ndproducer in this place instead.
The deprecated methods will be removed in the release after they were
first deprecated.
These new names and the deprecations are the first step towards renaming genrows/gencolumns #698