-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FromIterator trait rather than custom method #648
Conversation
It definitely looks like the right direction @max-sixty! Adding An important point to keep in mind when working on this PR: make sure to update ndarray for NumPy users to reflect the changes you are introducing! |
OK great; I updated the code throughout. Apart from the docs, what else? Do we need to wait for a minor version to merge the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some minor comments; everything else looks good to me.
I'm only now understanding how the rust import system works; I initially didn't realize you'd need an additional
use
statement each time to usefrom_iter
.
This is because from_iter
is provided by the FromIterator
trait, and FromIterator
is not included in the standard Rust prelude (so you have to explicitly use
it). In contrast, collect
is provided by the Iterator
trait, which is included in the standard Rust prelude.
Should we be using
.collect()
in the examples?
I think that's a bit nicer than adding use std::iter::FromIterator
, but either way is fine.
Or adding the
std::iter::FromIterator;
in thendarray
standard prelude?
I don't think we should do that because IMO that would be somewhat surprising.
Do we need to wait for a minor version to merge the
from_iter
removal?
We should include this as part of 0.13.0, which is the next release. (We've already merged some breaking changes into master
.)
Great, thanks for the thoughts. Updated on comments, lmk any final changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple of small fixes. This looks ready to merge once CI passes.
Thanks @jturner314 ! |
Merge conflicts resolved |
ref #642 (comment)
Is this the right direction?
I'm only now understanding how the rust import system works; I initially didn't realize you'd need an additional
use
statement each time to usefrom_iter
. Should we be using.collect()
in the examples? Or adding thestd::iter::FromIterator;
in thendarray
standard prelude?