-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward more iterator methods #614
Forward more iterator methods #614
Conversation
Merge main rep master to fork master
- nth - collect - any - all - find - find_map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few comments (primarily removing unnecessary Self: Sized
bounds). Additional methods that would be good to forward are:
count
last
position
rposition
@jturner314 I've removed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't realize that about rposition
. I think you're right that we can't provide a specialized implementation for it.
Everything looks good to me. I'll wait a little while to give anyone else a chance to comment, then I'll merge this.
Thanks!
Fixes #555
Forwarded the following
Iter
andIterMut
methods to theinner
iterator:nth
collect
all
any
find
find_map