Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set docs.rs targets #82

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Conversation

msiglreith
Copy link
Contributor

Only build for docs.rs targets and remove the rustdoc workaround

Fixes #80

@enfipy
Copy link
Contributor

enfipy commented Oct 14, 2020

Can you also increase the version number to trigger publish? Also, cargo-apk has an unpublished res folder fix

Copy link
Contributor

@francesca64 francesca64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@msiglreith
Copy link
Contributor Author

Thanks for reviewing, will bump the versions tomorrow (:

@msiglreith
Copy link
Contributor Author

I bumped the crate versions. could you check again please?

Copy link
Contributor

@francesca64 francesca64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@msiglreith msiglreith merged commit 7d36455 into rust-mobile:master Oct 19, 2020
MarijnS95 added a commit to MarijnS95/ndk that referenced this pull request Nov 3, 2020
This feature does not exist anymore and breaks the tests:

    error: Package `ndk v0.2.1 (/home/runner/work/android-ndk-rs/android-ndk-rs/ndk)` does not have these features: `rustdoc`

Fixes: 7d36455 ("Explicitly set docs.rs targets and bump versions to 0.2.1/0.5.3 (rust-mobile#82)")
MarijnS95 added a commit to MarijnS95/ndk that referenced this pull request Nov 3, 2020
This feature does not exist anymore and breaks the tests:

    error: Package `ndk v0.2.1 (/home/runner/work/android-ndk-rs/android-ndk-rs/ndk)` does not have these features: `rustdoc`

Fixes: 7d36455 ("Explicitly set docs.rs targets and bump versions to 0.2.1/0.5.3 (rust-mobile#82)")
MarijnS95 added a commit to MarijnS95/ndk that referenced this pull request Nov 3, 2020
This feature does not exist anymore and breaks the tests:

    error: Package `ndk v0.2.1 (/home/runner/work/android-ndk-rs/android-ndk-rs/ndk)` does not have these features: `rustdoc`

Fixes: 7d36455 ("Explicitly set docs.rs targets and bump versions to 0.2.1/0.5.3 (rust-mobile#82)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ndk-glue docs not building
3 participants