ndk-build,cargo-apk: Rename intent_filters back to intent_filter
#305
Conversation
|
For what's its worth, I approve of the reasoning behind the name change. It aligns with, as you pointed out, Androids own way of doing it 👍 |
|
Behind keeping the name as it was, to be very precise 😬 - it's more in-line with all the other properties too. Now let's see why NDK r23 is hitting us again - we already had to work around the |
|
A relaunch seems to have fixed it, but we should perhaps bump the cache (newer This is also the time ping @rust-windowing/publishers for suggestions/approval on breaking changes in a patch release if all the other versions are yanked; and I also need you to do the yanking if this is okay :) |
MarijnS95
force-pushed
the
back-out-of-intent_filters-rename
branch
from
c3255c4 to
890a50a
Compare
We commonly name vectors of items with their singular form so that they read nicer in TOML and XML (i.e. `[[intent_filter]]` adds a single entry to that list, and gets serialized as a single `<intent-filter>` XML element) and this matches Android's `intent-filter` naming too. This change in a6f3e13 ("ndk-build: Move default serialization of `MAIN` intent filter to `cargo-apk` (#241)") was made purely with `Vec` in mind, but breaks existing manifest parsing nor was anticipated to be a breaking change in this area as the README still carries `intent_filter` instead of `intent_filters` in its `Cargo.toml` metadata reference.
MarijnS95
force-pushed
the
back-out-of-intent_filters-rename
branch
from
890a50a to
968c5dc
Compare
|
After some thought I still don't think it's a good idea to publish a breaking change in a patch release and yank the older versions, so we'll release it as breaking change instead. @rust-windowing/publishers it'd still be nice to yank |
Fixes #304, CC @Hoodad
We commonly name vectors of items with their singular form so that they read nicer in TOML and XML (i.e.
[[intent_filter]]adds a single entry to that list, and gets serialized as a single<intent-filter>XML element) and this matches Android'sintent-filternaming too.This change in a6f3e13 ("ndk-build: Move default serialization of
MAINintent filter tocargo-apk(#241)") was made purely withVecin mind, but breaks existing manifest parsing nor was anticipated to be a breaking change in this area as the README still carriesintent_filterinstead ofintent_filtersin itsCargo.tomlmetadata reference.I want to try landing this without yet-another breaking release for
ndk-build: can we do that by yanking the previous releases? We don't need a breaking release forcargo-apkeither way, but it may be nice to yank their older releases too.