ndk: Remove and warn on trivial casts #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Jan 24, 2022
MarijnS95
force-pushed
the
trivial-casts
branch
from
e0c81dd to
90b6218
Compare
dvc94ch
approved these changes
Mar 16, 2022
`trivial-casts` is allowed by default as it still has some odd cases where the lint triggers incorrectly or is difficult to fix. For our intents and purposes however it works just fine and prevents against riddling the code with unnecessary - usually untyped - `as` casts. https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#explanation-22
MarijnS95
force-pushed
the
trivial-casts
branch
from
90b6218 to
98a4353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivial-castsis allowed by default as it still has some odd cases where the lint triggers incorrectly or is difficult to fix. For our intents and purposes however it works just fine and prevents against riddling the code with unnecessary - usually untyped -ascasts.https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#explanation-22
CC @zarik5, #216