-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package.include
to Cargo.toml
#165
base: main
Are you sure you want to change the base?
Conversation
Good catch, but I guess you can setup this at your application, not at lib level? |
Not sure what you mean, this is about crates.io releases. |
0a2b818
to
759dcc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question: how is README.md
from the root of this repo getting into the android-activity
subfolder? I don't see a symlink of sorts but it's in the packaged crate: https://docs.rs/crate/android-activity/latest/source/README.md
Its getting it from the |
759dcc9
to
733ad68
Compare
This reduces package size and notably prevents any bash files from landing on a users device.
733ad68
to
80e86d7
Compare
Ah, I didn't see that there's a
Yeah, that's correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks good to me too, thanks!
See the Cargo documentation on
package.include
.When using
cargo publish
every file is included and uploaded, even the shell files used to generate bindings not necessary during build time. Usingpackage.include
we can make sure that this doesn't happen and only what the user needs to compile the package or generate local documentation is included.