-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update license info #105
Update license info #105
Conversation
7eb8413
to
4cc6ba2
Compare
@xFrednet I don't think there's much to review here, just requires an action from you to update the placeholder crate, I'm going to mark this as blocked for now, feel free to do that whenever you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope my comments are not too nit picky 😅 We should also check that the licenses are correct in the Cargo.toml
files for crates.io
The placeholder crates can remain, as they are right now. Old versions can't be removed/modified anyways. The new licenses will be updated on crates.io when we push the version from this repo. Thank you for pointing it out though :) |
The badge takes licensing information from crates.io, not the github repo, that's why the crates need to be updated |
Looks like we have another reason to look forward to that day. ^^ IDK if I can reach the goal of completing the AST representation by March, but I want to be optimistic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll wait on the merge until the first version has been published, to ensure that the license shield is correct. If you want, you can also remove that line and r=me
. Then we can add it back with the first version :)
Thanks!
I don't like merging this with a wrong badge, I think what I can do is hardcode the badge for now, and make it link to the crates later. Or we can just leave this as blocked until the license has been updated, as it's not really urgent and shouldn't conflict with anything |
I'm fine with either option. Even if there will be conflicts, they should be simple to resolve. I'll add this to the milestone, to merge is shortly before releasing the crates :) |
Sure, I'm fine with leaving this blocked then |
Thank you for this PR! I'm currently updating the license information of the crates and Thank you, for the work you did, I highly appreciate it! |
Keeping license texts in sync with other rust repos (design repo probably needs this too).
License badge isn't quite correct, since placeholder on crates.io is purely MIT licensed, if marker-crate-reservations can be dual-licensed, like all other repos, and updated on crates.io, that would be great!
Context: