Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching prs to waiting on review when author has requested a review from an assignee #1733

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Oct 15, 2023

Adds a new config option:

[review-requested]
remove_labels = ["..."]
add_labels = ["..."]

When PR author requests a review from a PR assignee, triagebot will remove remove_labels and add add_labels.

Based on: rust-lang/rust#116661 (comment).
Todo: document this on forge.
cc @Mark-Simulacrum

src/handlers.rs Outdated Show resolved Hide resolved
Use the `issue_handlers!` instead
@Mark-Simulacrum Mark-Simulacrum merged commit 155434b into rust-lang:master Oct 15, 2023
2 checks passed
@WaffleLapkin WaffleLapkin deleted the review-requested branch October 15, 2023 22:34
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2023
…ested, r=Mark-Simulacrum

Enable `review-requested` feature for rustbot

See rust-lang/triagebot#1733.

r? `@Mark-Simulacrum`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 16, 2023
Rollup merge of rust-lang#116776 - WaffleLapkin:hell-yeah-review-requested, r=Mark-Simulacrum

Enable `review-requested` feature for rustbot

See rust-lang/triagebot#1733.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants