Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A case where rustbot assigned the PR author as the reviewer #1662

Closed
fmease opened this issue Oct 27, 2022 · 0 comments · Fixed by #1663
Closed

A case where rustbot assigned the PR author as the reviewer #1662

fmease opened this issue Oct 27, 2022 · 0 comments · Fixed by #1663

Comments

@fmease
Copy link
Member

fmease commented Oct 27, 2022

In rust-lang/rust#103648, rustbot assigned the PR author as the reviewer.
CC @jyn514

There appears to be some code specifically to avoid this problem but for some reason it did not succeed in this situation:

let filter = |name: &&str| -> bool {
let name_lower = name.to_lowercase();
name_lower != issue.user.login.to_lowercase()
&& !issue
.assignees
.iter()
.any(|assignee| name_lower == assignee.login.to_lowercase())
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant