Don't set is_preview for clippy and rustfmt
#103648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
T-release
|
r? @jyn514 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
|
lol |
|
@bors try Want to get a dev-static build here too so we can test it. |
|
⌛ Trying commit 1401417c677e86b53bfe98358476f94dc6d78b21 with merge 880ff5e0182c0ff4c0c48d3d87cfa6dc92d6dadc... |
|
☀️ Try build successful - checks-actions |
|
Kicked off dev-static for this try commit. |
|
Looks like this is working too :) I'll wait for #102565 to merge before approving this PR. |
|
@bors r=Mark-Simulacrum |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 12, 2022
Don't set `is_preview` for clippy and rustfmt These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components. Based on rust-lang#102565.
|
Failed in rollup: #104340 (comment) |
bors
added
S-waiting-on-author
jyn514
force-pushed
the
no-preview
branch
2 times, most recently
from
fd2fb15
to
da27179
Compare
|
@bors r=Mark-Simulacrum (Missed an instance of hardcoding |
|
📌 Commit da27179c337d9f91bba0af1ce229dbf13f36e0c4 has been approved by It is now in the queue for this repository. |
|
🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components.
rustbot
added
the
T-infra
jyn514
added
relnotes
|
@bors r=Mark-Simulacrum |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2022
Don't set `is_preview` for clippy and rustfmt These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components. Based on rust-lang#102565.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#103648 (Don't set `is_preview` for clippy and rustfmt) - rust-lang#104654 (Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests) - rust-lang#104793 (unstable-book: Add page for the `abi_efiapi` feature) - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection) - rust-lang#104849 (Migrate source code elements style to CSS variables) - rust-lang#104873 (RefCell::get_mut: fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
removed
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been shipped on stable for many years now and it would be very disruptive to ever remove them.
Remove the
-previewsuffix from their dist components.Based on #102565.