Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant try permissions to Rust for Linux marker team #1512

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

ojeda
Copy link
Contributor

@ojeda ojeda commented Jul 28, 2024

In order to test changes to the RFL CI job, if needed.

Cc: @Kobzol

@Kobzol
Copy link
Contributor

Kobzol commented Jul 28, 2024

Maybe we should add the permissions to the whole RfL group? Not sure what's the policy on try permissions for individual users (I'll let others chime in).

@ojeda
Copy link
Contributor Author

ojeda commented Jul 28, 2024

If you are comfortable adding all of them, of course! All but 2 of them, I think, are already Rust contributors.

@joshtriplett
Copy link
Member

👍 for granting try permissions to the entire RfL team within the teams repo.

@ojeda
Copy link
Contributor Author

ojeda commented Aug 1, 2024

Thanks Josh!

Updated PR.

@joshtriplett
Copy link
Member

@ojeda You should update the PR title too.

@ojeda ojeda changed the title Grant try permissions to myself Grant try permissions to Rust for Linux marker team Aug 2, 2024
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with @tmandry's approval here as lang-team lead here - but I think in general this makes a lot of sense.

@jackh726 jackh726 merged commit d1fd70b into rust-lang:master Aug 2, 2024
1 check passed
@ojeda ojeda deleted the ojeda-bors-rust-try branch August 2, 2024 16:31
@ojeda
Copy link
Contributor Author

ojeda commented Aug 2, 2024

Thanks Jack!

tmandry added a commit to tmandry/team that referenced this pull request Nov 8, 2024
This is so they can update the Fuchsia pin (e.g. rust-lang/rust#132294, which is only practical because of my status as compiler team member). For the same reason this was done for the Rust for Linux team in rust-lang#1512.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants