Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require AVX512 for 128/256-bit GFNI & VPCLMULQDQ intrinsics #1349

Merged
merged 2 commits into from
Oct 30, 2022

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Oct 29, 2022

Fixes #1325

@rust-highfive
Copy link

@Amanieu: no appropriate reviewer found, use r? to override

@calebzulawski
Copy link
Member

calebzulawski commented Oct 29, 2022

I think this requires a bit more changes to each individual intrinsic, including the EVEX ones. For example, from the Software Developer's Manual:
Screen Shot 2022-10-29 at 2 58 31 PM

Note that the 512-bit EVEX-encoded instructions only require AVX512F, but the smaller width EVEX instructions require AVX512VL (and neither require AVX512BW, which is what the intrinsics currently require). VAES and VPCLMULQDQ have similar requirements.

@Amanieu
Copy link
Member Author

Amanieu commented Oct 29, 2022

I left the EVEX-encoded 128/256-bit variant as they were ("avx512gfni,avx512bw,avx512vl").

The AVX512BW requirement comes from LLVM, which will refuse to emit the correct instruction if we don't add that target feature.

@calebzulawski
Copy link
Member

That's unfortunate, sure enough I see the same issue. I actually see an ICE when removing it. Do you know if there's an issue reported to LLVM?

@calebzulawski
Copy link
Member

I opened llvm/llvm-project#58687

@Amanieu Amanieu merged commit 676ca68 into rust-lang:master Oct 30, 2022
@Amanieu Amanieu deleted the gfni branch October 30, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avx512gfni and avx512vaes feature names might be misleading
3 participants