-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stabilization documentation #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaahc
force-pushed
the
stabilization-update
branch
from
March 3, 2022 22:55
3db14c8
to
fb852e9
Compare
scottmcm
reviewed
Mar 11, 2022
m-ou-se
reviewed
Mar 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm just slightly worried about making this process seem more daunting than it is in practice, especially for very small features. For very small features we currently don't expect experience reports or some proof that it's well-tested.
Co-authored-by: Mara Bos <[email protected]>
8 tasks
Co-authored-by: Josh Triplett <[email protected]>
yaahc
force-pushed
the
stabilization-update
branch
2 times, most recently
from
May 27, 2022 20:21
222bee8
to
e03b68b
Compare
yaahc
force-pushed
the
stabilization-update
branch
from
May 27, 2022 20:28
e03b68b
to
31712ea
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2022
generated from commit 22b26d5
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jul 3, 2022
…pdate, r=JohnTitor Link to stabilization section in std-dev-guide for library tracking issue template This shouldn't land until rust-lang/std-dev-guide#32 is merged.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 3, 2022
…pdate, r=JohnTitor Link to stabilization section in std-dev-guide for library tracking issue template This shouldn't land until rust-lang/std-dev-guide#32 is merged.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jul 3, 2022
…pdate, r=JohnTitor Link to stabilization section in std-dev-guide for library tracking issue template This shouldn't land until rust-lang/std-dev-guide#32 is merged.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jul 3, 2022
…pdate, r=JohnTitor Link to stabilization section in std-dev-guide for library tracking issue template This shouldn't land until rust-lang/std-dev-guide#32 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated this to include a section on partial stabilizations, though the example bit is currently incomplete because the PR I'm using as the basis for the example has not yet been opened. I've also updated the guide to stabilization to be based on the equivalent section that currently lives in the rustc-dev-guide1. Once we land this I plan to update the rustc-dev-guide to remove their duplicate section and instead cross reference the std-dev-guide.
Footnotes
https://rustc-dev-guide.rust-lang.org/stability.html#stabilizing-a-library-feature ↩