Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support panics across stack growth boundaries #7

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 16, 2018

No description provided.

@alexcrichton
Copy link
Member

Ok looks like the segfault here is showing up on MSVC

@alexcrichton
Copy link
Member

FWIW it's likely the case that https://github.com/alexcrichton/stacker/pull/4 needs to be dusted off to solve the MSVC issues

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 22, 2018

Would you be ok with disabling windows support for now and using the fallback?

@alexcrichton
Copy link
Member

It's fine to not support windows in this crate, but it's not fine to do that in the compiler unfortunately

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 22, 2018

it's not fine to do that in the compiler unfortunately

The compiler currently does not use this at all, using stacker while only supporting linux/mac would fix the regression issues we have open. There are none on windows as of now.

@alexcrichton
Copy link
Member

The stack size isn't really magically larger on Windows though, so the lack of reports on Windows doesn't mean it doesn't exist there, just that it hasn't been run into yet. It's the same bug on all platforms, and we can't fix it on 2/3 tier 1 platforms.

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 26, 2018

True, but I don't see #8 getting ready for being merged before the beta freeze.

Isn't it better to fix a bug on 2/3 of the platforms with a plan for fixing the last 1/3rd later, than to let the regression run into beta and stable?

@alexcrichton
Copy link
Member

I personally feel (others may wish to weigh in) that we can't fix 2/3 tier 1 platforms. This fix must be uniform across all tier 1 platforms.

@alexcrichton
Copy link
Member

I think this is supported and tested with https://github.com/alexcrichton/stacker/pull/8, so closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants