Statically linked the MSVC CRT #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
commented
Dec 2, 2016
| matrix: | ||
| - TARGET: i686-pc-windows-msvc | ||
| BUILD_MSI: 1 | ||
| - TARGET: i686-pc-windows-gnu | ||
| MINGW_URL: https://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-builds/4.9.2/threads-win32/dwarf/i686-4.9.2-release-win32-dwarf-rt_v4-rev4.7z/download | ||
| MINGW_URL: https://s3.amazonaws.com/rust-lang-ci |
There was a problem hiding this comment.
This was a bit of an unrelated cleanup, I switched to the url that we're using for Rust and a few other projects, and AWS is generally much more reliable than sourceforge
|
☔ The latest upstream changes (presumably #847) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This has some conflicts with the openssl-sys dep used by rustup's download crate. |
|
I may spend some time cleaning up the download crate soon to unblock this. |
|
Ok, updated the PR |
alexcrichton
force-pushed
the
libcmt
branch
2 times, most recently
from
e32fd94
to
274c182
Compare
|
openssl-sys still not working right |
This PR updates a few dependencies for support with `-C target-feature=+crt-static` and then updates CI to produce those relevant binaries on Windows. This should produce binaries that don't require the MSVC redistributables and instead work standalone.
|
Pushed some updates, let's see how it goes |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a few dependencies for support with
-C target-feature=+crt-staticand then updates CI to produce those relevantbinaries on Windows. This should produce binaries that don't require the MSVC
redistributables and instead work standalone.