Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(dev-guide): add guideline for atomic commits to the developer guide #3969

Merged
merged 1 commit into from
Jul 30, 2024
Merged

docs(dev-guide): add guideline for atomic commits to the developer guide #3969

merged 1 commit into from
Jul 30, 2024

Conversation

jtr860830
Copy link

This PR updates the developer guide to include information on atomic commits.

#3939 (comment)

@jtr860830 jtr860830 changed the title docs(dev-guide): add guideline for atomic commits to the developer guide WIP: docs(dev-guide): add guideline for atomic commits to the developer guide Jul 29, 2024
@jtr860830 jtr860830 changed the title WIP: docs(dev-guide): add guideline for atomic commits to the developer guide [WIP] docs(dev-guide): add guideline for atomic commits to the developer guide Jul 29, 2024
@jtr860830 jtr860830 marked this pull request as draft July 29, 2024 15:35
@jtr860830 jtr860830 marked this pull request as ready for review July 29, 2024 15:50
@jtr860830 jtr860830 changed the title [WIP] docs(dev-guide): add guideline for atomic commits to the developer guide docs(dev-guide): add guideline for atomic commits to the developer guide Jul 29, 2024
rami3l
rami3l approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtr860830 Looks good! Can we put this section at the beginning though?

@rami3l
Copy link
Member

rami3l commented Jul 30, 2024 •
edited
Loading

Also, it looks like this markdown was not covered by our previous API changes. process() is long gone and so is the macros helper crate... (Converted to #3970.)

@rami3l rami3l mentioned this pull request Jul 30, 2024
Closed
@jtr860830
Copy link
Author

@jtr860830 Looks good! Can we put this section at the beginning though?

OK. I'll update it.

docs(dev-guide): add guideline for atomic commits to the developer guide
c5141d4 
docs(dev-guide): put atomic commits at the beginning
@jtr860830 jtr860830 requested a review from rami3l July 30, 2024 06:38
@rami3l rami3l enabled auto-merge July 30, 2024 06:39
@rami3l rami3l added this pull request to the merge queue Jul 30, 2024
Merged via the queue into rust-lang:master with commit 03b7c56 Jul 30, 2024
27 checks passed
@jtr860830 jtr860830 deleted the update-dev-guide branch July 30, 2024 07:29
@rami3l rami3l mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtr860830 @rami3l