Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust source file structure #3889

Closed
wants to merge 0 commits into from
Closed

chore: adjust source file structure #3889

wants to merge 0 commits into from

Conversation

InfyniteHeap
Copy link
Contributor

To make the module hierarchy of source files more uniform, I changed the file structure to make the hierarchy fits the "new method".

@rami3l
Copy link
Member

rami3l commented Jun 17, 2024 •
edited
Loading

@InfyniteHeap Thanks for contributing!

However, this aspect of the coding style remains undecided, see #3883. I'd love to merge this patch if we eventually chose foo.rs over foo/mod.rs.

@rami3l rami3l linked an issue Jun 17, 2024 that may be closed by this pull request
Style: Decide between foo.rs and foo/mod.rs #3883
Open
rami3l
rami3l reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InfyniteHeap Regardless of the result of the discussion, could you please squash all commits into one? Thanks in advance!

@InfyniteHeap
Copy link
Contributor Author

@InfyniteHeap Regardless of the result of the discussion, could you please squash all commits into one? Thanks in advance!

Ok, and by the way I'll check whether there are something lost.

@InfyniteHeap InfyniteHeap requested a review from rami3l June 17, 2024 15:11
@InfyniteHeap InfyniteHeap marked this pull request as draft June 21, 2024 17:17
@InfyniteHeap
Copy link
Contributor Author

InfyniteHeap commented Jun 21, 2024 •
edited
Loading

This PR will keep closed until #3883 has any conclusions or consensus.

The reason why this PR was temporarily closed is that if there are some conflicts between this PR and some newer PRs, this PR will not be smoothly merged. To avoid this circumstance, only when this issue has been resolved will I reopen this PR and commit changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l Awaiting requested review from rami3l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style: Decide between foo.rs and foo/mod.rs
2 participants
@InfyniteHeap @rami3l