fix(utils): don't use O_NOFOLLOW in open_dir()
#3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
force-pushed
the
fix/unix-open-no-nofollow
branch
3 times, most recently
from
2d1a9f6
to
29ce9ee
Compare
djc
reviewed
Mar 27, 2024
rbtcollins
reviewed
Mar 27, 2024
rbtcollins
reviewed
Mar 27, 2024
rbtcollins
reviewed
Mar 27, 2024
rbtcollins
reviewed
Mar 27, 2024
rami3l
force-pushed
the
fix/unix-open-no-nofollow
branch
from
29ce9ee
to
f3b4dd5
Compare
rami3l
force-pushed
the
fix/unix-open-no-nofollow
branch
from
f3b4dd5
to
0e26879
Compare
rbtcollins
approved these changes
Mar 31, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3737.
For more context on this particular approach, see #3737 (comment).
Concerns