Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup-init.sh ksh and zsh compatibility fixes #3475

Merged
merged 2 commits into from
Oct 10, 2023
Merged

rustup-init.sh ksh and zsh compatibility fixes #3475

merged 2 commits into from
Oct 10, 2023

Conversation

alexhudspith
Copy link
Contributor

@alexhudspith alexhudspith commented Sep 8, 2023 •
edited
Loading

Fixes #3388
Fixes #3474

Tested with:

Shell Versions
bash (ubuntu) 5.1.16(1)-release
dash (ubuntu) 0.5.11+git20210903+057cd650a4ed-3build1
(debian) 0.5.12-2
ksh93 (illumos) Version jM 93u+ 2012-08-01
(ubuntu) Version AJM 93u+m/1.0.0-beta.2 2021-12-17
mksh (ubuntu) @(#)MIRBSD KSH R59 2022/01/31 +Debian
zsh (ubuntu) 5.8.1

@rami3l rami3l mentioned this pull request Oct 5, 2023
Closed
djc
djc approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very experienced with shell, but these changes seem to make sense to me.

rami3l
rami3l previously approved these changes Oct 10, 2023
View reviewed changes
rami3l
rami3l reviewed Oct 10, 2023
View reviewed changes
rustup-init.sh Show resolved Hide resolved
@rami3l rami3l dismissed their stale review October 10, 2023 10:30

Concern regarding setopt shwordsplit

@rami3l rami3l merged commit 3d6f8ea into rust-lang:master Oct 10, 2023
16 checks passed
@rami3l
Copy link
Member

rami3l commented Oct 10, 2023

@alexhudspith Sorry, I somehow missed your reply when approving those changes. The setopt local_options shwordsplit fix is still nice to have though: you can make a new PR for that if you like 🙇‍♀️

@alexhudspith
Copy link
Contributor Author

@rami3l No problem, thanks!

@rami3l rami3l mentioned this pull request Oct 12, 2023
Merged
@rami3l rami3l added this to the 1.27.0 milestone Jan 18, 2024
@rami3l rami3l mentioned this pull request Jan 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.27.0
3 participants
@alexhudspith @rami3l @djc