-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RUSTUP_TERM_COLOR
as an override environment variable
#3435
Conversation
Thank you for the patch.
I think its fine.
yes, unit tests in terminalsource would be best I think.
We generally don't expose variables as CLI parameters. |
e26ba9e
to
dc4921e
Compare
b1525de
to
b6cf380
Compare
Hmmm. IMO that CI error has nothing to do with the changes I've made... (cc #3437) |
(drive-by comment) Some related issue in rust-lang/cargo, if we want to make sure the behavior is in sync.
|
Closes #3433, getting my feet wet at the same time.
The variable name and the description are directly copied from the Cargo Book.
Concerns
Should we add a CLI flag (e.g.--color
) for this as well?If so, should we use Clap'senv
feature?