Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add up as an alias of the update command #3044

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

jbalintbiro
Copy link
Contributor

No description provided.

@jbalintbiro
Copy link
Contributor Author

The failing Linux x86_64 build seems to be unrelated to the PR, it failed to download the docker image sha256:9c23ba7777b9bca87c073017ab67e29c9ac1eb2e152bbd534f50d10ed40a637e before the build.

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks as we agreed

@kinnison kinnison merged commit 6bc5d2c into rust-lang:master Jul 20, 2022
@EwoutH
Copy link

EwoutH commented Apr 26, 2023

Is there documentation, a reference issue or other information on this change available? Since the PR and commit body don’t contain any motivation.

@kinnison
Copy link
Contributor

@EwoutH based on the timing and the way it was merged, I'd say this was discussed on the Rustup discord channel. Without digging through discord history I'd say it's likely that the submitter asked if we'd mind having the short alias and I wouldn't have objected to it and so they submitted the PR. What are you hoping for in terms of documented history?

@EwoutH
Copy link

EwoutH commented Apr 26, 2023

Mainly motivation / proportionality for adding the up alias. It seems the first abbreviation alias as far as I know.

@danielsilverstone-ct
Copy link
Contributor

Motivation - Someone wanted it enough to talk to us about it, justified it enough at the time for me to say "file a PR" and then they cared enough to actually file the PR including test code.

Proportionality - as abbreviated aliases go, it's far far less of a problem than rustup install being an "alias" for rustup toolchain install. I know a lot of people like the cargo short-aliases (eg cargo b cargo t etc) and most people only use the update feature of rustup on a regular basis. So rustup up kinda makes sense to have. These days I'd probably ask for it to be a hidden alias rather than a visible one, but I don't see why I'd deny its existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants