Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force-non-host flag to install subcommand #2968

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

Emilgardis
Copy link
Contributor

This touches on standing issue in cross-rs/cross#536

ping cross-rs/cross#554

@Emilgardis
Copy link
Contributor Author

Has anyone been able to review this? The CI failure is unrelated.

@Emilgardis
Copy link
Contributor Author

Emilgardis commented Apr 29, 2022

what's the status for this?

it's unexpected that install tells the user to use --force-non-host, but doesn't allow it in this context.

@kinnison
Copy link
Contributor

So rustup install is a hidden semi-alias for rustup toolchain install which is the official installation command for toolchains.

It's unfortunate that so many people expected rustup install and so I was not permitted to remove it (or even cause it to emit information about how it's deprecated) because the way it's implemented causes this kind of problem for people with legacy use of the hidden alias.

I'm OK with adding this patch, but honestly I'd rather that cross also switched to the correct command form.

Could you please rebase this patch atop current master so that the CI hopefully shows clean? I don't appear to be able to restart it.

@Emilgardis
Copy link
Contributor Author

I'm fine with changing the command used in cross, but I think it makes sense to make this work as well.

rebased

@Emilgardis
Copy link
Contributor Author

We actually already use toolchain install in the suggested change to use --force-non-host, but this pr doesn't touch that. Fixed that now :D

@kinnison kinnison merged commit feec94b into rust-lang:master Jun 4, 2022
@Emilgardis Emilgardis deleted the force-non-host-install branch June 7, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants