unpack_ram: More graceful handling of low unpack ram #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtcollins
reviewed
May 23, 2021
|
I think that sorts things out. |
rbtcollins
reviewed
May 28, 2021
rbtcollins
reviewed
May 28, 2021
Some people try setting RUSTUP_UNPACK_RAM below the minimum RAM needed for a threaded operation. Since, in principle, we need at least IO_CHUNK_SIZE and thus in theory 2x IO_CHUNK_SIZE, this change clamps the unpack RAM between minimum_ram and the computed maximum available RAM. Signed-off-by: Daniel Silverstone <[email protected]>
|
Cleaned up commit message, restored panic, and took your suggested message form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people try setting RUSTUP_UNPACK_RAM below the minimum
RAM needed for a threaded operation. Since, in principle,
we need at least IO_CHUNK_SIZE and thus in theory 2x IO_CHUNK_SIZE,
this change softens the failure mode from a panic to a warning
and then tries anyway. This is likely to succeed and as such
we'll let it happen. The warning should make it clear if there's
a problem, and should not appear for no-sysinfo platforms since
they default to minimum_ram anyway.
fix #2771