Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile in rust toolchain #2586

Merged
merged 4 commits into from
Dec 15, 2020
Merged

Profile in rust toolchain #2586

merged 4 commits into from
Dec 15, 2020

Conversation

kinnison
Copy link
Contributor

If I'm right this should fix #2579

@jyn514 Is this what you were expecting / desiring? If so, you can look at the built artifacts and fetch a test rustup to try.

jyn514
jyn514 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit. Thanks so much for adding this!

src/toolchain.rs Outdated Show resolved Hide resolved
tests/cli-rustup.rs Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Nov 30, 2020 •
edited
Loading

If so, you can look at the built artifacts and fetch a test rustup to try.

How can I look at the built artifacts? Found it, it was in the GitHub actions screen. I had to be logged in to download the artifact for some reason.

@jyn514
Copy link
Member

jyn514 commented Nov 30, 2020

Tested it out and it works great, just like I'd expect :)

toothbrush7777777
toothbrush7777777 reviewed Dec 9, 2020
View reviewed changes
src/config.rs Outdated Show resolved Hide resolved
@kinnison
Copy link
Contributor Author

I've worked through the code suggestions and if this goes green I'll merge.

@kinnison kinnison merged commit c44e884 into rust-lang:master Dec 15, 2020
@kinnison kinnison deleted the profile-in-rust-toolchain branch December 15, 2020 09:00
@ebroto ebroto mentioned this pull request Dec 15, 2020
Open
@polarathene polarathene mentioned this pull request May 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toothbrush7777777 toothbrush7777777 toothbrush7777777 left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust-toolchain should allow setting the equivalent of --profile minimal
3 participants
@kinnison @jyn514 @toothbrush7777777