Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce parent stat-per-file to stat-per-dir #1839

Merged
merged 1 commit into from
May 8, 2019
Merged

Reduce parent stat-per-file to stat-per-dir #1839

merged 1 commit into from
May 8, 2019

Commits on May 8, 2019

  1. Reduce parent stat-per-file to stat-per-dir 

    This is an installation microoptimisation for ~ 3% performance during
unpack performance: stat() calls are not free, involving path traversal,
ACL checking and so forth.

Before: 34s consistently to install rust-docs.
After: 32s-33s to install rust-docs.

A better still approach would be to handle creation errors by creating
the containing directories just in time, but that requires replacing
the tar extraction logic, which I haven't yet figured out how to layer
in cleanly.
    @rbtcollins
    rbtcollins committed May 8, 2019
    Configuration menu
    Copy the full SHA
    dae6915 View commit details
    Browse the repository at this point in the history