-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add miri to rustup #1606
Add miri to rustup #1606
Conversation
Would it make sense to have a |
I was considering that, but I felt like miri is niche enough so it won't impact too many ppl. I can change it though if anyone thinks it's worthwile |
I don't mind either way, just thought i'd mention it in case you hadn't already considered and discarded the idea :-D |
Change-wise this looks good 👍 but I would be more comfortable if it were rebased so that there aren't fixup commits in the sequence. I can do this if you don't have time, so long as someone can tell me how to update someone else's PR :-) |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @nrc I think this is good for merge. I can't see any reason why it'd break anything.
Thanks! |
Will miri component be availiable in the next rustup release (1.17.0)? |
It was just added to the distribution in rust-lang/rust#57086
This PR enables calling
cargo miri
after installing themiri
component