Prevent rustup update to a toolchain without rustc or cargo.
#1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Rust CI is misconfigured, it is possible to produce a nightly where `rustc` or `cargo` is not available. This makes the entire toolchain unusable (for one day at least). This PR tries to prevent the update operation from starting at all if these essential components are missing, so the user would still have a working though outdated toolchain. Resolves #1297.
|
Awesome, thanks! It looks like though that maybe one test is failing on Linux? (although it could be spurious, I haven't checked the tests here in awhile) |
Doesn't seem like caused by me... The latest build in master is failing with the same error also. |
|
Ok, I think I know what's going on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Rust CI is misconfigured, it is possible to produce a nightly where
rustcorcargois not available. This makes the entire toolchain unusable (for one day at least).This PR tries to prevent the update operation from starting at all if these essential components are missing, so the user would still have a working though outdated toolchain.
Resolves #1297.